John Patrick Diggins was a professor of history at the City University of New York Graduate Center, the author of more than a dozen books on widely variant subjects in American intellectual history, and one of the leading scholars in his field.